Skip to content

all deleting routes from a device - #97

Merged
jaxxstorm merged 3 commits into
mainfrom
delete_device_routes
Jul 31, 2026
Merged

all deleting routes from a device#97
jaxxstorm merged 3 commits into
mainfrom
delete_device_routes

Conversation

@jaxxstorm

Copy link
Copy Markdown
Owner

Signed-off-by: Lee Briggs lee@leebriggs.co.uk

Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Copilot AI review requested due to automatic review settings July 31, 2026 17:08
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4021f49f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/cli/testdata/leaf_commands.txt

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new tscli delete device routes subcommand to clear a device’s enabled subnet routes (without changing what the device advertises), including the underlying API wiring, docs generation output, and CLI test coverage.

Changes:

  • Introduces delete device routes CLI command and wires it into the delete device command tree.
  • Adds ClearDeviceRoutesJSON and adjusts routes update request marshaling to reliably send an empty routes: [] payload.
  • Updates generated docs and CLI tests/testdata to include the new command and its output.

Reviewed changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/cli/testdata/leaf_commands.txt Adds the new leaf command to the CLI command inventory used by tests.
test/cli/group_integration_test.go Adds an integration test asserting an empty routes list is sent.
test/cli/example_output_test.go Adds an example-output case for delete device routes.
pkg/tscli/audited_api.go Adds ClearDeviceRoutesJSON; ensures routes is never marshaled as null.
pkg/apitype/models.go Removes omitempty on routes so empty slices serialize as [].
docs/commands/tscli_delete_device.md Links the new subcommand from the parent delete-device docs.
docs/commands/tscli_delete_device_routes.md New generated docs page for tscli delete device routes.
docs/commands/README.md Adds the new command to the docs index.
docs/commands/_sidebar.md Adds the new command to the docs sidebar.
cmd/tscli/delete/device/routes/cli.go Implements the new delete device routes command.
cmd/tscli/delete/device/cli.go Registers the new routes subcommand under delete device.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/tscli/delete/device/routes/cli.go
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
@jaxxstorm
jaxxstorm merged commit 4d2d6d4 into main Jul 31, 2026
1 check passed
@jaxxstorm
jaxxstorm deleted the delete_device_routes branch July 31, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants