Add glm-5.3 model family entry - #54
Open
jatmn wants to merge 10 commits into
Open
Conversation
- Add exact glm-5.3 entry to z-ai.toml model-family catalog with proper 1M context window and auto_review_model_override - Update tests to verify glm-5.3 family loads with correct transforms - Update README and model-family-catalogs.md to list glm-5.3
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new GLM-5.3 reasoning_effort assertions in
first_class_reasoning_and_tool_translation_for_target_modelsare nearly identical to the GLM-5.2 ones; consider extracting a small helper that validates a family’sappend_chat_request_morphsto avoid duplication and keep future additions cheaper.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new GLM-5.3 reasoning_effort assertions in `first_class_reasoning_and_tool_translation_for_target_models` are nearly identical to the GLM-5.2 ones; consider extracting a small helper that validates a family’s `append_chat_request_morphs` to avoid duplication and keep future additions cheaper.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
jatmn
marked this pull request as draft
August 18, 2026 21:31
added 2 commits
August 18, 2026 14:37
…y assertions Following review feedback, extract a shared helper for validating append_chat_request_morphs so the GLM-5.2 and GLM-5.3 assertions are concise instead of nearly identical blocks. Future GLM-5.x additions become one-liners.
CI source checks flagged formatting issues. Running rustfmt cleans up the file's assert macro formatting, including our new code.
jatmn
marked this pull request as ready for review
August 18, 2026 21:50
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
assert_has_append_morph, the panic message"{label} family exists"reads like a successful condition; consider changing it to something like"{label} family should exist"or usingexpectfor a clearer failure message. - The helper name
assert_has_append_morphis a bit generic given it specifically checks for thereasoning.effort -> reasoning_effortrename; renaming it to something likeassert_has_reasoning_effort_append_morphwould make the intent clearer at the call sites.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `assert_has_append_morph`, the panic message `"{label} family exists"` reads like a successful condition; consider changing it to something like `"{label} family should exist"` or using `expect` for a clearer failure message.
- The helper name `assert_has_append_morph` is a bit generic given it specifically checks for the `reasoning.effort -> reasoning_effort` rename; renaming it to something like `assert_has_reasoning_effort_append_morph` would make the intent clearer at the call sites.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an exact model-family entry for Z.ai's GLM-5.3 model, which was previously only matched by the broad
glm-5*pattern.Changes
z_ai_glm_5_3entry with:auto_review_model_override = "glm-5.3"reasoning_effortforwarding alongsidethinking.type(like GLM-5.2)reasoning_efforttransformWhy needed
Previously,
glm-5.3was only matched by the broadglm-5*pattern which:reasoning_effortnativelyauto_review_model_overrideThis caused issues with network escalation requests being auto-denied due to incorrect or missing model metadata.
Validation
cargo test --locked(647 passed, 0 failed)cargo build --lockedcargo clippy --locked --all-targets --all-features -- -D warnings(clean)git diff --check(clean)Summary by Sourcery
Add first-class GLM-5.3 support with accurate metadata and provider-compatible reasoning transformations.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: