Skip to content

[codevoyager] fix: ChainerBackend falls through backends on PasswordDeleteError - #762

Open
codevoyager-ai-dev wants to merge 1 commit into
jaraco:mainfrom
codevoyager-ai-dev:codevoyager-1784257179
Open

[codevoyager] fix: ChainerBackend falls through backends on PasswordDeleteError#762
codevoyager-ai-dev wants to merge 1 commit into
jaraco:mainfrom
codevoyager-ai-dev:codevoyager-1784257179

Conversation

@codevoyager-ai-dev

Copy link
Copy Markdown

The method previously only caught NotImplementedError, causing PasswordDeleteError from a higher-priority backend to propagate immediately without trying lower-priority backends. This meant that if a password was stored in a lower-priority backend (e.g. SecretService), but a higher-priority backend (e.g. DBusKeyring) was now available but did not have the password, the delete would fail with PasswordDeleteError: Password not found.

Fix: Catch PasswordDeleteError in addition to NotImplementedError in delete_password, so the chainer continues to the next backend when one raises PasswordDeleteError.

Testing:

  • test_delete_password_falls_through_on_password_delete_error — verifies fall-through when highest-priority backend raises PasswordDeleteError
  • test_delete_password_skips_not_implemented — verifies fall-through on NotImplementedError (existing behavior)
  • All existing tests pass

Closes #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChainerBackend not deleting password from lower priority backend

1 participant