fix(build): ensure format file triggers publish and loads from source - #94
Merged
Merged
Conversation
- add LS2Issue.format.ps1xml to publish.yml push trigger paths - add explicit FormatsToProcess to Locksmith2.psd1 for source imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the build/publish pipeline so that
LS2Issue.format.ps1xmlchanges are always included in published packages and the module loads format data correctly when imported from source.Problem
LS2Issue.format.ps1xml, so format-only updates could be skipped during release.Locksmith2.psd1did not declareFormatsToProcess, relying on a runtime fallback inLocksmith2.psm1for source imports.Changes
LS2Issue.format.ps1xmlto the push trigger paths in.github/workflows/publish.yml.FormatsToProcess = @('LS2Issue.format.ps1xml')toLocksmith2.psd1.Verification
Import-Module Locksmith2.psd1from source now loads all 21 format views (Default,Summary, 19*Detailedviews, andFull).Files changed
.github/workflows/publish.ymlLocksmith2.psd1