docs(release-readiness): resolve 05 Pester tests vs artifact layout - #13
Open
jakehildreth wants to merge 1 commit into
Open
docs(release-readiness): resolve 05 Pester tests vs artifact layout#13jakehildreth wants to merge 1 commit into
jakehildreth wants to merge 1 commit into
Conversation
- Rewrite tests to PSScriptRoot-relative path: Artefacts/Unpacked/ADCSGoat/ADCSGoat.psd1 - Drop dead BuildHelpers BH* env vars (PSStucco scaffolding fossils, unset since 7b8c203) - Delete changelog-version-match assertion: release-time concern, enforced by 04's post-build assertion and 11's publish gate - Artifact tests skip with a clear reason when no build exists, keeping fresh-clone Invoke-Pester green
jakehildreth
force-pushed
the
docs/release-readiness-05
branch
from
August 17, 2026 15:37
f3a9381 to
f42251a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision
Update the tests to the real artifact layout. The
Output/<Module>/<version>/contract died with the PSStucco/BuildHelpers build system in7b8c203and is not restorable.The rewrite (when executed)
Manifest.tests.ps1+Help.tests.ps1derive paths from$PSScriptRoot→Artefacts/Unpacked/ADCSGoat/ADCSGoat.psd1(canonical layout per ticket 03). BuildHelpersBH*env vars deleted — nothing has set them since the PSPublishModule migration; both files currently fail before their first assertion.Build/Build-Module.ps1first") when no artifact exists, instead of failing. A fresh-cloneInvoke-Pesterruns green;Meta.tests.ps1is unaffected (it lints source, runs standalone).