Repository navigation
Fix unit tests on 32-bit targets - #331
Merged
Merged
Conversation
- check `ExpiringCache` field types instead of comparing `size_of` against `UnboundCache` - assert only consistency for a wrong hash passed to `LruCache::pop_raw_with_hash`, and fix its doc - add `make tests/32bit` and `make tests/32bit/docker` to run the suite on `i686-unknown-linux-gnu` - run `make tests/32bit` in CI Fixes #330
jaemk
force-pushed
the
261012.32-bit-test-fixes
branch
from
October 12, 2026 11:21
fd8e680 to
37ba53c
Compare
jaemk
enabled auto-merge (squash)
October 12, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpiringCachefield types with an exhaustive destructure instead of comparingsize_ofagainstUnboundCache(aBox<[Slot]>is the same size as anAtomicU64on 32-bit)LruCache::pop_raw_with_hashgets a wrong hash, and fix its doc: a wrong hash may still hit, since hashbrown reads only the low 32 bits on 32-bitmake tests/32bit(unit and integration tests oni686-unknown-linux-gnu, default and no default features) andmake tests/32bit/docker(same target in a container built fromdocker/i686/Dockerfile, no local 32-bit toolchain needed)test-32bitCI job runningmake tests/32bitFixes #330