Add optional PCRE2 CI coverage - #27
Merged
jacklilyhello merged 1 commit intoJun 23, 2026
Merged
jacklilyhello merged 1 commit into
jacklilyhello merged 1 commit into
Conversation
jacklilyhello
deleted the
codex/fix-pr-#25-in-new-codex-environment-2026-06-23-09-03-47
branch
June 23, 2026 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pcre2engine selection.Description
.github/workflows/pcre2.ymlthat runs onpushandpull_request, installspkg-configandlibpcre2-dev, and executesmake test-pcre2andmake build-pcre2under the job namePCRE2 / Optional tagged build.internal/matcher/regex_backend.go,internal/matcher/pcre2.go,internal/matcher/pcre2_stub.go), and adapt the regex matcher to compile rules with a selectable engine (re2orpcre2).regex_engine, backend-unavailable skipped counts, PCRE2-compatible/incompatible counts, and implementeffectiveRegexEngineandpcre2Compatiblehelpers ininternal/bundled/runtime.goso PCRE2 activation is optional and does not affect default RE2 behavior.internal/matcher/pcre2_test.goandinternal/engine/bundled_runtime_test.go) and add a PCRE2-tagged bundled runtime test (internal/engine/bundled_runtime_pcre2_test.go) that validates activation and runtime stats when built/ran with-tags pcre2.test-pcre2andbuild-pcre2, update config/defaults/docs (config.example.yml,docs/bundled-rules-phase-b-runtime.md,CODEX.md,README.md,CHANGELOG.md) to document the optional PCRE2 engine and the developer log entry describing this follow-up.Testing
go test ./...which completed successfully for the repository packages.go vet ./...which completed successfully with no reported issues.go build ./...andCGO_ENABLED=0 go build ./...which both succeeded.make verify-bundled-netease,make fmt-check,make smoke, andmake e2ewhich all returned successfully.make gosecwhich completed and reported zero blocking issues in the current baseline.go test -tags pcre2 ./...,go build -tags pcre2 ./...,make test-pcre2, andmake build-pcre2, and all PCRE2-tagged tests and builds passed in the local environment after the test fixes were applied.Codex Task