Conversation
client.up used eval on foreign_option_N, which re-parses the server PUSH. Read the value with a quoted printf and match it as a quoted string so command substitution in the push is not executed. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
What kind of change does this PR introduce?
PR checklist
What is the current behavior?
On Linux, OpenVPN runs
client.upas root (script-security 2). The script reads eachforeign_option_Nvalue, which comes from the server PUSH, witheval. That re-parses the value as shell. Thecasetest was also unquoted.Issue number: N/A
What is the new behavior?
The value is read with
printf '%s'inside quotes, and thecaseword is quoted. DNS and domain parsing stays the same. A PUSH value is not executed as shell.TestClientUpDoesNotEvalForeignOptionchecks the script text and that a value containing$(...)stays literal.Does this PR introduce a breaking change?
Normal
dhcp-option DNSanddhcp-option DOMAINpushes still update DNS.Other information
Base is
development. This is Linux only. The macOS DNS script reads these values from the environment withouteval.