Conversation
Hello is on the EAA skip list, and the reply included the API session token. Drop that token and the account id for a connection that has not passed the password check. After the first successful check, send a full Hello so the UI can load the session. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
An unauthenticated connection receives a Hello whose account id and session token are empty on the wire. The unit test of helloForClient does not call notifyClients. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
What kind of change does this PR introduce?
PR checklist
What is the current behavior?
Hellois on the Enhanced App Authentication skip list, so the password is not checked. The Hello reply still includes the account id and the API session token.The UI reads that session from the first Hello, before the user has entered the EAA password.
Issue number: N/A
What is the new behavior?
Until this connection has passed the EAA check, a Hello reply sent to it has an empty account id and an empty session token. Paranoid-mode status, version, and settings are unchanged, so the UI can still show the password prompt.
After the first successful password check, the daemon sends a full Hello to that connection. The UI then loads the session the same way it does today.
When EAA is off, Hello is unchanged.
TestHelloForClientOmitsSessionUntilEAAcovers the redaction.Does this PR introduce a breaking change?
With EAA off, clients see the same Hello. With EAA on, the session arrives on the Hello that follows a successful password check instead of on the first Hello.
Other information
Base is
development.