Conversation
If /Applications/IVPN.app is not root-owned, the helper checked the agent binary signature and then chowned the whole bundle to root before exec. Refuse to launch instead. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
What kind of change does this PR introduce?
PR checklist
What is the current behavior?
If
/Applications/IVPN.appis not owned by root, the privileged helper checks the signature ofIVPN Agentonly, then runschown -R 0:0on the whole app and launches the agent. Files in the bundle other than that binary are not part of the check.is_safe_diralready requires both uid 0 and gid 0 (07bd5323). This PR does not change that test.A private report of this was closed without a code change (GHSA-9vqc-pp5f-wmc9).
Issue number: N/A
What is the new behavior?
When the bundle is not safe, the helper logs the same message and exits. It does not change ownership and it does not launch the agent.
check_signatureis removed because that was its only caller.Does this PR introduce a breaking change?
A bundle that is already root:wheel still launches. A bundle that is not root-owned no longer gets repaired by the helper. Install or repair has to fix ownership before the helper will start the agent.
Other information
Base is
development.