Feature/527 spdx SBOM - #576
Closed
redcatbear wants to merge 4 commits into
Closed
Conversation
|
kaklakariada
requested changes
Aug 21, 2026
| * or go to [GitHub Actions](https://github.com/itsallcode/openfasttrace/actions/workflows/release.yml) and start the `release.yml` workflow on branch `main`. | ||
| 2. Update the title and description of the newly created [GitHub release](https://github.com/itsallcode/openfasttrace/releases). | ||
| 3. After some time the release will be available at [Maven Central](https://repo1.maven.org/maven2/org/itsallcode/openfasttrace/openfasttrace/). | ||
| 3. Download the JAR, checksum, and SPDX 3 SBOM from the release assets. The SBOM file is named `openfasttrace-$VERSION.spdx3.json`. |
Contributor
There was a problem hiding this comment.
Why do we need this step in the release process? If we need to verify the content of the sbom. please specify it here. Or better automate it ;)
Comment on lines
+72
to
+73
| .addInputs(baseDir.resolve("product/pom.xml")) // | ||
| .addInputs(baseDir.resolve(".github/workflows/github_release.sh")) // |
Contributor
There was a problem hiding this comment.
Suggested change
| .addInputs(baseDir.resolve("product/pom.xml")) // | |
| .addInputs(baseDir.resolve(".github/workflows/github_release.sh")) // | |
| .addInputs(baseDir.resolve("product/pom.xml")) | |
| .addInputs(baseDir.resolve(".github/workflows/github_release.sh")) |
Not necessary any more with the new formatter settings
Contributor
There was a problem hiding this comment.
This calculates the sbom only for the product jar. If we need to publish the sbom to Maven Central, we need a separate ticket.
Comment on lines
+208
to
+213
| <licenseOverwrite> | ||
| <target>both</target> | ||
| <groupId>org.itsallcode.openfasttrace</groupId> | ||
| <artifactId>openfasttrace-testutil</artifactId> | ||
| <licenseString>GPL-3.0-only</licenseString> | ||
| </licenseOverwrite> |
Contributor
There was a problem hiding this comment.
This should be in test scope. Do we still need this here as test scope is excluded from the sbom?
Collaborator
Author
|
Solved by #527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SPDX 3 SBOM.