Refactor plugin integration tests - #82
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Gradle plugin integration tests by extracting common Gradle TestKit setup/execution and assertions into a reusable fixture, reducing duplication across the main plugin test suite.
Changes:
- Introduce
PluginTestFixtureto centralize GradleRunner configuration, execution, and common assertions (task outcomes, output, report-file content). - Update
OpenFastTracePluginTestto use the fixture for running builds and asserting outcomes/report contents. - Update housekeeping files (
CHANGELOG.md,.gitignore) to reflect the PR and ignore additional Eclipse settings.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/java/org/itsallcode/openfasttrace/gradle/PluginTestFixture.java | New shared integration-test fixture wrapping Gradle TestKit runs and assertions. |
| src/test/java/org/itsallcode/openfasttrace/gradle/OpenFastTracePluginTest.java | Refactor existing integration tests to use PluginTestFixture. |
| CHANGELOG.md | Add entry for PR #82. |
| .gitignore | Ignore additional Eclipse preference files. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces code duplication and improves maintainability of plugin integration tests