27: Support location specification item IDs at a certain line. - #28
Open
redcatbear wants to merge 2 commits into
Open
27: Support location specification item IDs at a certain line.#28redcatbear wants to merge 2 commits into
redcatbear wants to merge 2 commits into
Conversation
|
Contributor
Author
|
@sophokles73, Could you please do a review? |
sophokles73
reviewed
Aug 17, 2026
Comment on lines
213
to
+231
| @@ -211,7 +228,7 @@ private void processForwardingBlock(final String skippedType, final StructuralNo | |||
| this.listener.beginSpecificationItem(); | |||
| this.listener.setId(specItemId); | |||
| this.listener.setLocation(location); | |||
| this.listener.addCoveredId(coveredSid); | |||
| this.listener.addCoveredId(coveredLocatedSpecificaitonItemId); | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| final LocatedSpecificationItemId coveredLocatedSpecificationItemId = | |
| createLocatedSpecificationItemId(coveredSpecItems.get(0), block); | |
| final SpecificationItemId coveredSpecificationItemId = coveredLocatedSpecificaitonItemId.getId(); | |
| final LocatedSpecificationItemId specItemId = LocatedSpecificationItemId.builder() | |
| .id(new SpecificationItemId.Builder() | |
| .artifactType(skippedType) | |
| .name(coveredSpecificationItemId.getName()) | |
| .revision(coveredSpecificationItemId.getRevision()) | |
| .build()) | |
| .range(coveredLocatedSpecificationItemId.getRange()) | |
| .build(); | |
| final Location location = getLocation(block); | |
| LOG.fine(() -> "adding forwarding specification item [ID: %s, location: %s]".formatted(specItemId, | |
| @@ -211,7 +228,7 @@ | |
| this.listener.beginSpecificationItem(); | |
| this.listener.setId(specItemId); | |
| this.listener.setLocation(location); | |
| this.listener.addCoveredId(coveredLocatedSpecificationItemId); |
Comment on lines
20
to
21
| <!-- Upgrading to 3.0.1 causes test failures, see https://github.com/itsallcode/openfasttrace-asciidoc-plugin/issues/19 --> | ||
| <asciidoctor.version>3.0.0</asciidoctor.version> |
Collaborator
There was a problem hiding this comment.
FMPOV this should be addressed as part of releasing 1.0.0
Contributor
Author
There was a problem hiding this comment.
I agree 100%. I took a shot at it two weeks back. Seems to be a bigger refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.