Repository navigation
chore(deps): update dependency aquaproj/aqua to v2.66.1 - #540
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.66.0→v2.66.1Release Notes
aquaproj/aqua
v2.66.1Compare Source
Bug Fixes
#5577 GitHub Artifact Attestations: Pass GitHub access tokens from the keyring or ghtkn to GitHub CLI
aqua verifies GitHub Artifact Attestations by running GitHub CLI (
gh attestation verify).Before, aqua didn't pass GitHub access tokens managed by the keyring or ghtkn to GitHub CLI, so GitHub CLI called GitHub API without authentication unless
GH_TOKEN,GITHUB_TOKEN,AQUA_GITHUB_TOKEN, orgh auth loginwas used.So you couldn't verify packages of private repositories with the keyring or ghtkn, and the verification of public packages could fail because of the rate limit.
aqua now tries GitHub access tokens in order until the verification succeeds.
If GitHub CLI has its own credential (
GH_TOKEN,GITHUB_TOKEN, orgh auth login):AQUA_GITHUB_TOKENOtherwise:
AQUA_GITHUB_TOKENThe same access token isn't tried twice even if it comes from different sources.
Access tokens which are invalid or hit the rate limit aren't used for the rest of the process.
If the verification fails, the error has the link to the error code 008, which describes the causes and solutions.
Behavior changes
The verification isn't skipped on authentication errors anymore
Before, aqua skipped the verification if the output of GitHub CLI contained
gh auth loginorset the GH_TOKEN environment variable.Now the verification fails, because skipping the verification installs packages without verifying them.
In practice, this rarely affects you.
aqua runs GitHub CLI with
GH_HOST=github.com(#4038), so GitHub CLI skips its authentication check and can verify attestations without an access token.Rate limit errors weren't skipped before either.
If the verification fails because of the rate limit, please pass a GitHub access token by
GITHUB_TOKEN,AQUA_GITHUB_TOKEN, the keyring, or ghtkn.On GitHub Actions, you can pass
${{ github.token }}.If you can't verify packages, you can disable the verification explicitly, though we don't recommend it.
export AQUA_DISABLE_GITHUB_ARTIFACT_ATTESTATION=truePrecedence of
AQUA_GITHUB_TOKENIf GitHub CLI has its own credential, it now takes precedence over
AQUA_GITHUB_TOKEN.Before,
AQUA_GITHUB_TOKENoverrode the credential stored bygh auth login.If GitHub CLI's own credential fails,
AQUA_GITHUB_TOKENis tried next, so the result is the same in most cases.The exception is HTTP 404 for a private package without private: true.
aqua treats such a package as public and fails immediately without trying other access tokens.
Please set
private: trueto private packages.Retries
Before, aqua retried any failure of GitHub CLI up to 5 times.
Now aqua retries only temporary failures such as HTTP 5xx and network errors, and fails immediately on failures it doesn't recognize.
Others
#5578 #5585 #5587 ci: Update workflows
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.