Skip to content

fix: make manifest_version change backward compatible #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khalsz wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix: make manifest_version change backward compatible #89

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4051fbe
fix: make manifest_version change backward compatible
khalsz Jun 4, 2026
1da348e
fix: format fix
khalsz Jun 4, 2026
025a9f8
Updating to check for version 1 and adding a warning
jholloc Jun 16, 2026
18ef6d3
applying ruff formatting
jholloc Jun 16, 2026
a3f28d1
adding missing import
jholloc Jun 16, 2026
c929e23
fixing linter issues
jholloc Jun 16, 2026
20a4ac4
correcting update
jholloc Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/simdb/cli/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import os
import re
import urllib.parse
import warnings
from enum import Enum, auto
from pathlib import Path
from typing import Dict, Iterable, List, Optional, TextIO, Tuple, Type, Union
Expand Down Expand Up @@ -564,7 +565,18 @@ def validate(self) -> None:
)

if "manifest_version" not in self._data:
print("warning: no version given in manifest, assuming version 2.")
if "version" in self._data and self._data["version"] == 1:
warnings.warn(
"Found version field for manifest version 1, please update "
"to manifest_version",
DeprecationWarning,
stacklevel=1,
)
self._data["manifest_version"] = self._data.pop("version")
else:
warnings.warn(
"No version given in manifest, assuming version 2.", stacklevel=1
)

version = self.version

Expand Down
Loading