Update flask to version 3#82
Open
Yannicked wants to merge 3 commits into
Open
Conversation
Yannicked
requested review from
SimonPinches,
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
olivhoenen
reviewed
May 21, 2026
|
|
||
| from simdb.config import Config | ||
| from simdb.database.models import Base | ||
| from simdb.json import CustomDecoder, CustomEncoder |
Contributor
There was a problem hiding this comment.
Is this removal of the CustomEncoder/CustomDecoder has anything to do with the bump of Flask version?
Collaborator
Author
There was a problem hiding this comment.
Yes, flask 3 does not have app.json_encoder or app.json_decoder
We are already using Pydantic for the JSON decoding, so we shoudn't need it anymore
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| @pytest.fixture(scope="function") |
Contributor
There was a problem hiding this comment.
Same question about these changes, are they intended in this Flask 3 bump?
Collaborator
Author
There was a problem hiding this comment.
Yes, it has to do with the lifetime of the flask app during testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates flask to version 3. This makes SimDB compatible with python>=3.14