Recognise a wrapped sign-convention sentence - #27
Merged
Conversation
The gated matrix job ran the bare suite on 3.13 and an instrumented one on 3.12, and the instrumentation was almost the whole cost of that leg: 903 of its 920 seconds against 594 for the uninstrumented sibling executing the same tests. Every merge paid for a coverage report nobody reads to decide whether to merge. The gate is now the bare suite on both supported interpreters. A separate coverage job repeats the suite once under branch instrumentation and carries both Codecov uploads; it is continue-on-error and outside the required checks, so a Codecov outage or a coverage drop reports without blocking.
Branch-coverage instrumentation was the whole cost of the slow job: 903 of its 920 seconds, against 594 for the uninstrumented sibling running the same suite. The gate now runs the bare suite on both supported interpreters and the coverage build carries its uploads in a job no merge waits on.
The match used a no-newline character class, so a sign-convention sentence the catalog writer had wrapped ended at the first soft break and the standalone-paragraph check then inspected the middle of a paragraph, refusing an entry the writer itself produced. The match now runs to the sentence terminator across line breaks. Recovered from a worker that verified the change and died before committing it.
The match used a no-newline character class, so a sentence the catalog writer had wrapped ended at the first soft break and the standalone-paragraph check then inspected the middle of a paragraph, refusing an entry the writer itself produced. Writer and validator disagreed inside one package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sign-convention validator now recognises its sentence after the catalog
writer has wrapped it.
The match used a no-newline character class, so a wrapped sign-convention
sentence ended at the first soft line break. The standalone-paragraph check
then inspected the middle of a paragraph and refused the entry — an entry this
package's own writer had produced. Writer and validator disagreed inside one
package, and every catalog export carrying a long sign-convention sentence was
refused.
The match now runs to the sentence terminator across line breaks. A
sign-convention sentence genuinely not separated by a blank line is still
refused.
Suite: 2046 passed, 34 skipped, 82 xfailed.