Feature/replace dim x with identifier#86
Conversation
jwasikpsnc
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
|
Alias is now put into "name" response field. |
…re/replace_dimX_with_identifier # Conflicts: # backend/ibex/data_source/imas_python_source.py # backend/tests/conftest.py # backend/tests/test_data_endpoints.py
There was a problem hiding this comment.
In you plot example from #86 (comment) the units for R and Z are wrong, they should be [m]
| :param grid_node: IDSNode (named dimX, X = [1...N]) | ||
| :return: | ||
| """ | ||
| result = {"alias": None, "unit_alias": None} |
There was a problem hiding this comment.
You should better use keys named "axis_labels" and "units", speking of alias here is going to be confusing in the long term as in the DD identifiers alias metadata has another meaning
There was a problem hiding this comment.
Unit alias won't work until new version of DD and IMAS-Python is released.
Code extracting them is left for the future.
Will rename alias->axis_label and unit_alias->unit
There was a problem hiding this comment.
Unit alias won't work until new version of DD and IMAS-Python is released. Code extracting them is left for the future.
In DD units are there already (only axis_label is missing but you are not using it) since 4.1.0, in IMAS-Python, the identifiers API has been extended to allow access to units since 2.3.0 which was released last week.
There was a problem hiding this comment.
Done
Ready for further review
|
Got the correct units now, thanks! |
2 participants
plot_dataresponse coordinates dict:alias- alias to the coordinate name e.g.Rfordim1(depends on identifier)unit_alias- alias to coordinate unit. Currently always None (waiting for new DataDictionary and IMAS-Python release):unitsmetadata to Identifiers IMAS-Python#131@mfiaudrin-epsyl FYI: keys in the response are always there, if there is no alias, then
alias=NoneExample response: