fix: guard ProxyPostAtomicFetch on emulated path - #24
Closed
itej89 wants to merge 1 commit into
Closed
Conversation
itej89
force-pushed
the
feat/ep-rdma-sharing-fix-r2-3-fetch-guard
branch
from
August 28, 2026 22:11
c6ca1c2 to
be1dcc3
Compare
Add ProxyCmdFlags enum (PROXY_FLAGS_DEFAULT, PROXY_FLAGS_FETCH_REQUIRED). ProxyPostAtomicFetch sets PROXY_FLAGS_FETCH_REQUIRED. CPU DrainCq: - Any non-default flag on emulated path → MORI_APP_ERROR + PROXY_ERROR - PROXY_FLAGS_FETCH_REQUIRED on native path → writes ibuf result Native atomics remain Mellanox-only. Confirmed ionic native atomics fail (CQE transport retry exceeded on DO AINIC). Addresses PR ROCm#558 round-2 review comment R2-3. Co-Authored-By: Claude <noreply@anthropic.com>
itej89
force-pushed
the
feat/ep-rdma-sharing-fix-r2-3-fetch-guard
branch
from
August 28, 2026 22:17
be1dcc3 to
737e866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses PR ROCm#558 round-2 review comment R2-3.
ProxyPostAtomicFetchreturnsring->cmds[slot].resultwhich is 0 on the SEND_WITH_IMM emulated path (ionic/bnxt) — silent wrong value. Nobody calls it today, but a future caller would get corrupted data.Fix:
ProxyPostAtomicFetchsetsflags=2("fetch result required"). CPU DrainCq checks this flag:MORI_APP_ERRORand returnsPROXY_ERRORinstead of silent 0Native atomics remain Mellanox-only — tested
IBV_WR_ATOMIC_FETCH_AND_ADDon DO AINIC ionic and confirmed failure:CQE error status=12 (transport retry counter exceeded).Test plan
🤖 Generated with Claude Code