fix: check wc.status before opcode, use MORI logger in proxy - #19
Merged
itej89 merged 2 commits intoAug 27, 2026
Merged
Conversation
itej89
force-pushed
the
feat/ep-rdma-sharing-fix-proxy-safety
branch
2 times, most recently
from
August 27, 2026 21:36
d29560e to
42f0352
Compare
- Check wc.status first in DrainCq — on error, opcode may be garbage - Null-check atomic target address from SEND_WITH_IMM payload - Replace fprintf with MORI_LOG_ERROR in proxy_thread.cpp - Replace fprintf with MORI_APP_INFO in init.cpp proxy log line Addresses PR ROCm#558 review comments #1, #3, and #7. Co-Authored-By: Claude <noreply@anthropic.com>
itej89
force-pushed
the
feat/ep-rdma-sharing-fix-proxy-safety
branch
from
August 27, 2026 21:36
42f0352 to
d2c08a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses PR ROCm#558 review comments #1, #3, and #7.
wc.statusbeforewc.opcodeinDrainCq— on error, opcode may be garbagefprintfwithMORI_CORE_ERRORin proxy_thread.cpp,MORI_SHMEM_INFOin init.cppTest plan
🤖 Generated with Claude Code