Skip to content

fix: check wc.status before opcode, use MORI logger in proxy - #19

Merged
itej89 merged 2 commits into
feat/ep-rdma-sharingfrom
feat/ep-rdma-sharing-fix-proxy-safety
Aug 27, 2026
Merged

fix: check wc.status before opcode, use MORI logger in proxy#19
itej89 merged 2 commits into
feat/ep-rdma-sharingfrom
feat/ep-rdma-sharing-fix-proxy-safety

Conversation

@itej89

@itej89 itej89 commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

Addresses PR ROCm#558 review comments #1, #3, and #7.

Test plan

  • EP benchmark on DO AINIC: Dispatch Pass, Combine Pass
  • Dispatch avg 32.45 GB/s, Combine avg 56.77 GB/s (consistent)

🤖 Generated with Claude Code

Guard against dereferencing a null pointer from the SEND_WITH_IMM
payload. The address comes from the wire — skip the atomic if zero.

Addresses PR ROCm#558 review comments #1 and #7 (wc.status check was
already implemented in the current code).

Co-Authored-By: Claude <noreply@anthropic.com>
@itej89
itej89 force-pushed the feat/ep-rdma-sharing-fix-proxy-safety branch 2 times, most recently from d29560e to 42f0352 Compare August 27, 2026 21:36
- Check wc.status first in DrainCq — on error, opcode may be garbage
- Null-check atomic target address from SEND_WITH_IMM payload
- Replace fprintf with MORI_LOG_ERROR in proxy_thread.cpp
- Replace fprintf with MORI_APP_INFO in init.cpp proxy log line

Addresses PR ROCm#558 review comments #1, #3, and #7.

Co-Authored-By: Claude <noreply@anthropic.com>
@itej89
itej89 force-pushed the feat/ep-rdma-sharing-fix-proxy-safety branch from 42f0352 to d2c08a7 Compare August 27, 2026 21:36
@itej89
itej89 merged commit b8a5d7f into feat/ep-rdma-sharing Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant