fix: add _tunable_defines() to _hipcc_device_bc for Triton/FlyDSL - #17
Merged
itej89 merged 1 commit intoAug 27, 2026
Merged
Conversation
_hipcc_device_bc omitted _tunable_defines(), so device bitcode was built without -DMORI_PROXY_ENABLED. This compiled out the proxy transport dispatch branches in shmem kernels, causing Triton/FlyDSL EP ops to silently skip the proxy path. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses PR ROCm#558 review comment #4.
_hipcc_device_bcomitted_tunable_defines(), so device bitcode compiled by Triton/FlyDSL was built without-DMORI_PROXY_ENABLED. This compiled out the proxy transport dispatch branches in shmem kernels (_PROXY_ELSEmacro,ShmemQuietThreadproxy drain), causing Triton/FlyDSL EP ops to silently skip the proxy path.One-line fix: add
*_tunable_defines(),to the_hipcc_device_bccommand list, matching_hipcc_gencowhich already has it.Test plan
🤖 Generated with Claude Code