Repository navigation
Prepare v0.5.2 CLI boundaries - #44
Merged
Merged
Conversation
Selector-to-Agent filter lowering now lives in collector::cupti and aggregate merging, selector hints, and result construction live in core::gpu_aggregate, mirroring syscall_aggregate::analyze. The CLI keeps only collector lifecycle checks and type mapping. A kernel aggregate without a name or a zero-count group now returns an explicit error instead of panicking or emitting a NaN mean. Also correct the stale discover help text.
Rust 1.99 clippy adds `assert_is_empty`, which rejects `assert!(x.is_empty())` under `-D warnings`. Rewrite the affected test assertions as `assert_eq!`/`assert_ne!` so failures print the offending value; CLI stderr checks now print the decoded text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collector::cupti(cupti/filter.rs) and GPU aggregate merging, selector hints, and result construction intocore::gpu_aggregate, mirroringsyscall_aggregate::analyze. The CLI keeps only collector lifecycle checks and type mapping (main.rs4327 → 3962 lines).discoverhelp text to match its implemented behavior.Verification
just fmt-check,just lint,just test(153 Rust tests, 8 new),just test-install,just test-skill-installjust test-cupti-live,just test-multisource-live,just test-nvtx-live,just benchmark-aggregateon RTX 3060test-release-livewithPYTORCH_ENVis running locally before tagging.