Implement ISMIP7 conventions and match with ISMIP7 data request#2
Open
Implement ISMIP7 conventions and match with ISMIP7 data request#2
Conversation
Focus on getting ISMIP7 tests up and running. Adding support for three options: "ismip7_scalars", "ismip7_vars", "ismip7", where the last is a combination of both.
refactor checker to isolate tests as separate functions update to latest ISMIP7 data request
…t to variable_list
xylar
reviewed
Apr 29, 2026
| conda activate isschecker | ||
| ``` | ||
|
|
||
| Dependencies: Python 3.9, `numpy`, `pandas`, `xarray`, `cftime`, `netCDF4`, `tqdm`. |
Member
There was a problem hiding this comment.
Python 3.9 is past end of life. Many of the other dependencies in https://github.com/ismip/ISM_SimulationChecker/blob/main/isschecker_env.yml are super old and need to be updated:
name: isschecker
channels:
- conda-forge
- defaults
dependencies:
- python=3.14
- pip=26.0.1
# Core scientific python
- numpy=2.4.3
- pandas=3.0.2
- tqdm=4.67.3
# Spatial packages
- xarray=2026.4.0
- cftime=1.6.5
- netcdf4=1.7.4
Member
There was a problem hiding this comment.
I verified on my laptop that this combination is installable. This is all the latest versions of each dependency available on conda-forge right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major overhaul of the checker to bring it up to date with the ISMIP7 data request and conventions.
The full list of implemented checks is at the top of compliance_checker.py.
There is also a new test/generate_test_files.py which can write a full ISMIP7 submission (with synthetic data in range) as a template for modellers to look at and that passes all the tests.
The ISMIP6 logic has been removed and both scripts now rely on sheet conventions/ISMIP7_variable_request.xlsx.