feat: System to include Observed Data#67
Open
Ragansu wants to merge 3 commits intoiris-hep:featworkspace_schema_updatefrom
Open
feat: System to include Observed Data#67Ragansu wants to merge 3 commits intoiris-hep:featworkspace_schema_updatefrom
Ragansu wants to merge 3 commits intoiris-hep:featworkspace_schema_updatefrom
Conversation
Import utils in training module
|
|
||
| self.weight_arrays_unbinned = self._get_asimov_weights_array() | ||
|
|
||
| self.observed_array = self._get_observed_arrays() |
Collaborator
There was a problem hiding this comment.
COuld we rename this to something more intuitive - such as observed_hist ?
|
|
||
| return dict_datasets | ||
|
|
||
| def load_observations_from_config(self) -> Dict: |
Collaborator
There was a problem hiding this comment.
Could this be a part of the load_datasets_from_config method above? With a keyword argument asking if the user wants to also extract observed data? Some code repetition could be avoided since in most cases people would want to extract observed data I imagine (even if it is Asimov)
Collaborator
|
Once you address the comments above this PR should be ready to merge, but just as a sanity check would be nice to update the model building and fitting parts in one of the examples with this new schema. I can upload the saved models and datasets somewhere for you to rerun the relevant parts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a dedicated system to include observed events / test events seperated from template dataset is required for proper statistical test, This PR addresses this concern.
User now need to define a Obsereved Section in their Config file. Example Below
Happy to get your feed back
RC