Skip to content

1 - #734

Draft
lidaobing wants to merge 1 commit into
mainfrom
bf_better_async_send_message
Draft

1#734
lidaobing wants to merge 1 commit into
mainfrom
bf_better_async_send_message

Conversation

@lidaobing

@lidaobing lidaobing commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Propagate GLib-style errors through message sending, and refactor message sending to use GTask-based asynchronous APIs with proper completion handling.

New Features:

  • Introduce GTask-based asynchronous message sending and completion handling for CoreThread and iptux-service.

Bug Fixes:

  • Avoid throwing exceptions when a pal does not exist and instead report a GLib error and log a warning.
  • Ensure socket creation and TCP send/receive failures propagate detailed GError information back to callers.
  • Surface message send failures to the UI and IPC service finish callbacks instead of silently succeeding.

Enhancements:

  • Refactor Command and CoreThread send routines to return boolean success flags with optional GError out parameters.
  • Replace detached std::thread usage with GLib asynchronous task infrastructure for better integration with cancellables and callbacks.

Copilot AI review requested due to automatic review settings July 27, 2026 06:18
@lidaobing
lidaobing marked this pull request as draft July 27, 2026 06:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@github-actions

Copy link
Copy Markdown

Test Results

69 tests  ±0   66 ✅  - 3   4s ⏱️ -1s
32 suites ±0    0 💤 ±0 
 1 files   ±0    3 ❌ +3 

For more details on these failures, see this check.

Results for commit e73991e. ± Comparison against base commit d232d08.

@sourcery-ai

sourcery-ai Bot commented Jul 27, 2026

Copy link
Copy Markdown

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants