Skip to content

APIs for external libraries - #87

Draft
fedebenelli wants to merge 10 commits into
devfrom
external_apis
Draft

fedebenelli wants to merge 10 commits into
devfrom
external_apis

Conversation

@fedebenelli

@fedebenelli fedebenelli commented Jul 12, 2024

Copy link
Copy Markdown
Member

This pull request focuses on the wrapping of external libraries, at the end of the pull requests it should include

  • Wrappers to known libraries:

    • FeOs

      • Object saving pointer
      • json string generator
      • Model calling interface
    • teqp

      • Object saving pointer
      • json string generator
      • Model calling interface
  • Maybe some C API standard type?

  • Move the C-API of yaeos-python to be called from other C libraries

@codecov

codecov Bot commented Jul 12, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.69663% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.97%. Comparing base (e8aa28b) to head (5765ab1).
⚠️ Report is 1533 commits behind head on dev.

Files with missing lines Patch % Lines
src/fitting/fit_nrtl_mhv.f90 0.00% 38 Missing ⚠️
src/models/external_apis/feos.f90 75.75% 8 Missing ⚠️
src/fitting/fitting.f90 58.33% 4 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (42.69%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #87      +/-   ##
==========================================
- Coverage   93.60%   91.97%   -1.63%     
==========================================
  Files          53       56       +3     
  Lines        2392     2468      +76     
  Branches      179      179              
==========================================
+ Hits         2239     2270      +31     
- Misses        105      150      +45     
  Partials       48       48              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fedebenelli
fedebenelli marked this pull request as draft August 13, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant