Repository navigation
fix(ci): Node.js 20 → 24 — naprawia build po plotly.js 4 (#885) - #886
Merged
Merged
Conversation
Po #885 'yarn install' w obrazie testowym i w jobie vitest pada na 'The engine "node" is incompatible with this module. Expected version ">=22.0.0". Got "20.20.2"'. Node 20 jest i tak EOL od kwietnia 2026. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V5NgRzHfVBb6qGi5agZDvw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Po #885 (plotly.js 4.1.2) na `dev` nie buduje się obraz testowy ani job vitest:
plotly.js 4 wymaga Node ≥22, a obrazy i CI miały przypięty Node 20 (EOL od kwietnia 2026). Lokalnie build szedł na Node 26, więc tego nie złapałem, a czerwonego CI na #885 nie sprawdziłem przed merge'em.
Zmiana
Node 20 → 24 (aktualny LTS) we wszystkich pięciu miejscach:
docker/bpp_base/Dockerfile:ARG NODEJS_VERSIONdocker-compose.test.yml: wartość domyślna.github/workflows/tests.yml: env obrazu testowego isetup-nodedla vitest.github/workflows/release-candidate.yml: env builda RCW zależnościach nie ma modułów natywnych ani górnych ograniczeń wersji Node (sass to dart-sass, esbuild, grunt, vitest).
Odblokowuje też #385.
🤖 Generated with Claude Code
https://claude.ai/code/session_01V5NgRzHfVBb6qGi5agZDvw