Skip to content

tests create temp files in test temp dir #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gammazero wants to merge 2 commits into from
+12 −18
Closed

tests create temp files in test temp dir #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43726c5
tests create temp files in test temp dir
gammazero Jul 7, 2026
991e405
use t.Setenv
gammazero Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions setup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,15 @@ func TestLogToFileAndStderr(t *testing.T) {
}()

// setup file
logfile, err := os.CreateTemp("", "go-log-test")
logfile, err := os.CreateTemp(t.TempDir(), "go-log-test")
require.NoError(t, err)
require.NoError(t, logfile.Close())
defer os.Remove(logfile.Name())

os.Setenv(envLoggingFile, logfile.Name())
defer os.Unsetenv(envLoggingFile)
t.Setenv(envLoggingFile, logfile.Name())

// set log output env var
os.Setenv(envLoggingOutput, "file+stderr")
defer os.Unsetenv(envLoggingOutput)
t.Setenv(envLoggingOutput, "file+stderr")

SetupLogging(configFromEnv())

Expand All @@ -84,13 +83,13 @@ func TestLogToFileAndStderr(t *testing.T) {

func TestLogToFile(t *testing.T) {
// get tmp log file
logfile, err := os.CreateTemp("", "go-log-test")
logfile, err := os.CreateTemp(t.TempDir(), "go-log-test")
require.NoError(t, err)
require.NoError(t, logfile.Close())
defer os.Remove(logfile.Name())

// set the go-log file env var
os.Setenv(envLoggingFile, logfile.Name())
defer os.Unsetenv(envLoggingFile)
t.Setenv(envLoggingFile, logfile.Name())

SetupLogging(configFromEnv())

Expand Down Expand Up @@ -118,8 +117,7 @@ func TestLogLabels(t *testing.T) {
}()

// set the go-log labels env var
os.Setenv(envLoggingLabels, "dc=sjc-1,foobar") // foobar to ensure we don't panic on bad input.
defer os.Unsetenv(envLoggingLabels)
t.Setenv(envLoggingLabels, "dc=sjc-1,foobar") // foobar to ensure we don't panic on bad input.
SetupLogging(configFromEnv())

log := getLogger("test")
Expand Down Expand Up @@ -147,8 +145,7 @@ func TestSubsystemLevels(t *testing.T) {
}()

// set the go-log labels env var
os.Setenv(envLogging, "info,test1=debug")
defer os.Unsetenv(envLoggingLabels)
t.Setenv(envLogging, "info,test1=debug")
SetupLogging(configFromEnv())

log1 := getLogger("test1")
Expand Down Expand Up @@ -234,8 +231,7 @@ func TestLogToStderrAndStdout(t *testing.T) {
os.Stdout = stdout
}()

os.Setenv(envLoggingOutput, "stdout+stderr")
defer os.Unsetenv(envLoggingOutput)
t.Setenv(envLoggingOutput, "stdout+stderr")

SetupLogging(configFromEnv())

Expand Down Expand Up @@ -275,8 +271,7 @@ func TestLogToStdoutOnly(t *testing.T) {
os.Stdout = stdout
}()

os.Setenv(envLoggingOutput, "stdout")
defer os.Unsetenv(envLoggingOutput)
t.Setenv(envLoggingOutput, "stdout")

SetupLogging(configFromEnv())

Expand Down Expand Up @@ -346,8 +341,7 @@ func TestSlogHandler_MatchesSlogDefault(t *testing.T) {
defer slog.SetDefault(originalDefault)

// Enable automatic capture
os.Setenv(envCaptureSlog, "true")
defer os.Unsetenv(envCaptureSlog)
t.Setenv(envCaptureSlog, "true")

// Setup with capture enabled
SetupLogging(Config{
Expand Down
Loading