feat(dapp-kit): add useWalletStoreSync - #77
Open
panteleymonchuk wants to merge 8 commits into
Open
Conversation
…ect-on-protect-route
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…ect-on-protect-route
|
This pull request has been deployed to Vercel.
|
marc2332
requested changes
Apr 24, 2026
Comment on lines
+19
to
+22
| const isProtectedRoute = useMemo( | ||
| () => PROTECTED_ROUTES.some((route) => pathname.startsWith(route.path)), | ||
| [pathname], | ||
| ); |
| selectorKey: 'connectionStatus', | ||
| ): 'disconnected' | 'connecting' | 'connected'; | ||
|
|
||
| // Implementation |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Implementation |
| @@ -0,0 +1,46 @@ | |||
| // Copyright (c) 2025 IOTA Stiftung | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2025 IOTA Stiftung | |
| // Copyright (c) 2026 IOTA Stiftung |
| // Function overloads for type safety | ||
| export function useWalletStoreSync(selectorKey: 'lastConnectedWalletName'): string | null; | ||
| export function useWalletStoreSync( | ||
| selectorKey: 'connectionStatus', |
Collaborator
There was a problem hiding this comment.
Why do we need this variant? Its never called.
Contributor
Author
There was a problem hiding this comment.
It was called in the prev vesions of this code. Removed.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
Problem:
localStorage, standard selectors return stale values briefly before hydration completes. This causes ConnectionGuard to incorrectly think no wallet is persisted and prematurely redirect users from protected routes, even though auto-connect is about to restore their session.
Solution:
propagation delay. This provides immediate access to persisted state during hydration.
Security: