Fix privilege escalation in profile update - #34
Open
sxyrxyy wants to merge 1 commit into
Open
Conversation
PUT /api/user/profile handed the whole request body to User.update, and User.update's whitelist still had role/organizationId/isActive/permissions in it. Any logged-in user could set role=super_admin on their own account. Allowlist the profile fields at the route and drop the privilege columns from User.update. Role and permissions already have their own admin endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PUT /api/user/profilepassed the whole request body intoUser.update, andUser.update's field whitelist still includedrole,organizationId,isActiveandpermissions. Any logged-in user could setrole: "super_admin"on their own account in a single request, then sail through everyrequireSuperAdmin()/requirePermission('canManageAllUsers')check.With self-registration on, that's an unauthenticated path to full super_admin over the whole tenant set.
Fix
firstName,lastName,phone,bio, etc.) instead of passingreq.bodystraight through.role,organizationId,isActiveandpermissionsfromUser.update's whitelist so they can't be set via the self-service path even if a caller tries. Role and permission changes already have dedicated admin endpoints.Repro (before)
The caller's own row becomes
role = super_admin. After this PR the same request has no effect on role.Notes