Repository navigation
feat: lan ipv4 cidr block support - #709
Merged
Merged
Conversation
avirtopeanu-ionos
requested review from
a team,
adeatcu-ionos,
cavramoniu-ionos,
cristiGuranIonos and
rmocanu-ionos
and
a balanced review from Copilot
and removed request for
a team
November 4, 2026 12:26
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The PR relies on POST/PATCH support for ipv4CidrBlock despite the vendored SDK marking it read-only, requiring confirmation from the current API contract or successful live integration results.
No open issues 🎉
What changed in this PR
Adds private LAN IPv4 CIDR configuration to the compute CLI, allowing users to choose a range during creation and change it later.
Changes:
- Adds
--ipv4-cidrto LAN create and update commands. - Displays
IPv4CidrBlockby default in LAN output. - Adds unit and integration coverage, command documentation, and changelog entries.
| File | Description |
|---|---|
test/suites/compute/networking.bats |
Adds CIDR display, create/update, and invalid-input checks. |
services/cloudapi-v6/constants.go |
Defines the IPv4 CIDR flag name. |
docs/subcommands/Compute Engine/lan/update.md |
Documents CIDR updates and an example. |
docs/subcommands/Compute Engine/lan/list.md |
Documents IPv4 CIDR output. |
docs/subcommands/Compute Engine/lan/get.md |
Documents IPv4 CIDR details. |
docs/subcommands/Compute Engine/lan/delete.md |
Updates the available output columns. |
docs/subcommands/Compute Engine/lan/create.md |
Documents CIDR selection and automatic assignment. |
commands/compute/lan/update.go |
Registers the update flag and adds help text. |
commands/compute/lan/run_lan.go |
Passes IPv4 CIDR values into API requests. |
commands/compute/lan/list.go |
Updates list help to describe IPv4 CIDR output. |
commands/compute/lan/lan.go |
Adds the default IPv4 CIDR column. |
commands/compute/lan/lan_test.go |
Tests CIDR rendering and request properties. |
commands/compute/lan/get.go |
Updates get help to describe IPv4 CIDR details. |
commands/compute/lan/create.go |
Registers the create flag and adds help text. |
CHANGELOG.md |
Records the new flag and output column. |
Review effort: Balanced
cristiGuranIonos
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for updating the IPv4 CIDR Block on LANs