Repository navigation
fix(diagram): extend keeps stretched children inside the container's padding - #217
Open
ionos-landgraf-vin wants to merge 1 commit into
Open
ionos-landgraf-vin wants to merge 1 commit into
ionos-landgraf-vin wants to merge 1 commit into
Conversation
…ner inside its padding The cross-axis branch of Expander#expand passed the container's full outer size to its children, so they sat flush on its border. Pass the inner size (minus padding/title) and centre on the inner area, like the single-child case. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a container with several children (a stack/layer) is grown by `extend`, the cross-axis branch of `Expander#expand` passed the container's full outer size to its children. They ended up flush on its border instead of inside its padding. The single-child branch already subtracted the inset.
Fix
Pass the inner size (target minus padding and, on the height axis, the title bar) and centre the children on the inner area. `stretch_children` (main axis) needed no change: the children share exactly the extra the container grew by, so the padding stays.
Test plan
🤖 Generated with Claude Code