Repository navigation
fix(markdown): [[Target|label]] in a list item no longer becomes a table row - #214
Merged
Merged
Conversation
…ble row Kramdown reads every line with an unescaped pipe as a table row, so "- Related: [[A/B|a]], [[C/D|d]]" was cut into cells and WikiLinks then matched across them. The pipe inside a wiki link is escaped before parsing, code is left as written. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|as a table row, so a list item like- Related: [[A/B|a]], [[C/D|d]]was cut into table cells, andWikiLinksthen matched[[...]]across</td><td>, rendering broken links.Markdown.documentnow escapes the|inside[[...]]before parsing. Fenced code and inline code are left as written (they would show the backslash). Wiki links in real table cells still work.Test plan
test/markdown_test.rb: list item, table cell, code span / fenced blockbundle exec rake(tests, steep, rubocop)🤖 Generated with Claude Code