select float32 for krea2 denoise on mps - #9579
Open
grunblatt-git wants to merge 1 commit into
Open
Conversation
grunblatt-git
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
September 8, 2026 22:59
github-actions
Bot
added
python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a Performance Improvement for Krea2 on MPS devices where float32 outperforms bfloat16.
For other devices the previous behavior remains unchanged if
precision: autois set in the config. Otherwise the custom precision setting is honored for krea2 inference.Related Issues / Discussions
Closes #9575
Checklist
What's Newcopy (if doing a release after this PR)