fix(sidebar): cache drift on new actionable sidebar - #682
Open
stijnmoreels wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for invictus-for-azure ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
stijnmoreels
marked this pull request as ready for review
August 12, 2026 08:16
stijnmoreels
marked this pull request as draft
August 12, 2026 08:17
stijnmoreels
changed the title
stijnmoreels
marked this pull request as ready for review
August 12, 2026 08:55
stijnmoreels
marked this pull request as draft
August 12, 2026 08:55
stijnmoreels
marked this pull request as ready for review
August 12, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new sidebar with mobile support was incorrectly using caches that stores the user's choice. This PR fixes that by removing the snapshots entirely. Slower to toggle the navigation, but more correct.