[rid] Add lock on subscriptions#1523
Draft
the-glu wants to merge 1 commit into
Draft
Conversation
Member
Author
|
I switched that one to draft. Running tests with the new proposed tool in interuss/monitoring#1519, 27 queries in // show those results: 
Things seems faster without latency, but as soon as it increase things explode, and that probably dues to similar reason to SCD: too much contentions. Trying again with minimum number of queries in //, 9. we get: 
Same problem, but with higher latency. Not sure how to decide between different tradeoff. With this PR, request can be processed faster (especially with light load), but there is a point (dependant on latency) when it's worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a lock on RID's subscriptions when working on ISAs.
It fixes #1509 (or at least improve the situation)
This follow the same logic that the one in SCD, preventing (improving) cascade of transactions restart observed with tracing with parameters / code in #1509 (comment)
However ISA don't create a automatic subscription, so the case with lot of subscriptions may not be relevant.
This has been verify locally, by running tests as described previously (parameters + specific non-merged version of monitoring repo). Timeout present before are gone.
Before:
After:
(Notice there is an unrelated error on subscriber notification)