Skip to content

Pending operations: notification log, resend and filter (registrar_center2#237) - #2981

Open
OlegPhenomenon wants to merge 5 commits into
masterfrom
issue-237-pending-notifications
Open

OlegPhenomenon wants to merge 5 commits into
masterfrom
issue-237-pending-notifications

Conversation

@OlegPhenomenon

@OlegPhenomenon OlegPhenomenon commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Backend for internetee/registrar_center2#237

  • New table domain_pending_notifications: the registrant change confirmation, new registrant notice and delete confirmation emails are logged with time and recipient addresses, only after successful delivery (Observers::PendingNotificationObserver, X-Pending-Notification header).
  • GET /repp/v1/domains/:name returns pending: { requested_at, notifications } (sponsoring registrar only, only while a registrant confirmation is awaited).
  • POST /repp/v1/domains/:name/pending_notification resends the confirmation email.
  • q[with_pending_operation]=1 in the domain list (pendingUpdate / pendingDeleteConfirmation / pendingDelete).
  • The delayed registrant change confirmation and notice jobs skip sending when the change is no longer pending (cancelled, confirmed or rejected within the one-minute delay). Before, a registrant could get "change cancelled" followed by a confirmation request with a dead link.
  • Deploy: run migrations.

repp-apidoc is not updated.

Tested on staging (registry1-dev with registrar1-dev and registrant1-dev): delayed emails logged after delivery, resend, delete confirmation, confirmation via the emailed link, cancel within the first minute.

OlegPhenomenon and others added 3 commits November 5, 2026 12:23
…ing (registrar_center2#237)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er2#237)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…#237)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

…r_center2#237)

The log row was written inside the mailer before delivery, so a failed
delivery was logged as sent and every job retry added another row. Log from
an ActionMailer observer instead.
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

3 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

…nding (registrar_center2#237)

- Confirmation and notice emails are sent a minute after the request; a change cancelled, confirmed or rejected in that minute no longer triggers a confirmation request with a dead link.
- Pending notification test runs the delayed jobs after the request, as Sidekiq does.
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deploy Complete!

Property Value
App registry
Slot 1
URL https://registry1-dev.cloud.tld.ee
Namespace registry1-dev

(Environment ready for testing)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants