Repository navigation
Compare full identity on registrant change (#2977) - #2980
Open
OlegPhenomenon wants to merge 1 commit into
Open
OlegPhenomenon wants to merge 1 commit into
OlegPhenomenon wants to merge 1 commit into
Conversation
Domain update treated a registrant as unchanged when only ident matched, skipping verification for entities with the same code in another country or of another type. Use Contact#identical_to? instead (#2977) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2977
Domain update treated the registrant as unchanged when only
identmatched, so verification was skipped for a different entity with the same code in another country or of another type.Now
Contact#identical_to?is used:ident,ident_typeandident_country_codemust all match. This flag also drives the registrant-change-prohibited and dispute checks.Tests: two new EPP update tests (different country, different type) fail on the old code and pass now; related EPP/REPP update and domain tests pass.
🤖 Generated with Claude Code