Expose the matched operation on SchemaValidator::OpenAPI3 - #479
Merged
Conversation
Applications sometimes need the operation the validator matched, for example to use its original_path as a low-cardinality metrics label. The validator already holds it in @operation_object with no public reader, forcing instance_variable_get. Add a documented attr_reader.
amogiska
force-pushed
the
expose-operation-object
branch
from
September 1, 2026 17:25
48f52e9 to
32011e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAPI 3 schema validator matches the request to an operation and holds it in
@operation_object, but offers no public reader, so applications that want the matched operation have to useinstance_variable_get.One concrete use case: recording HTTP request metrics labeled by the matched
original_pathtemplate, which keeps the label set bounded by the schema's paths instead of raw request paths (see ubicloud/ubicloud#6271, where a committee maintainer asked us to get a supported API here rather than read the ivar).This adds a documented
attr_reader :operation_object(returns theOperationWrapper, or nil when nothing matched) plus a test.