Skip to content

add Semgrep SAST and secrets scan workflow - #19

Merged
lukaszstolarczuk merged 2 commits into
mainfrom
scan
Oct 21, 2026
Merged

lukaszstolarczuk merged 2 commits into
mainfrom
scan

Conversation

@rbanka1

@rbanka1 rbanka1 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Add a Semgrep CI workflow that runs code (SAST) and secrets scanning on pull requests, workflow_dispatch, and push to the main branch. The job runs on the semgrep/semgrep container, checks out the repository.

Comment thread .github/workflows/semgrep.yml Fixed
@@ -0,0 +1,5 @@
# Copyright (c) 2026 Intel Corporation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this file e.g. to within .github dir? or some of its subdir?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it has to be here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

-f VAL, -c VAL, --config=VAL (absent SEMGREP_RULES env)
           YAML configuration file, directory of YAML files ending in
           .yml|.yaml, URL of a configuration file, or Semgrep registry entry
           name.

ref. https://docs.semgrep.dev/cli-reference

can you please move it into .github dir?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. I know it says "create in the root dir", but did you try it to configure it elsewhere?

tbh, I don't like extra yml file in the root dir, just for the sake of one CI workflow... If it's really not working, then ok, but please check if you haven't yet.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved to .github and looks good for now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaay, perfect, thanks

@lukaszstolarczuk

lukaszstolarczuk commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

When ready please make use of the commit convention (committed in our repo) and also update the PR title accordingly. Also you have to add a signoff to your commit.

Comment thread .github/workflows/semgrep.yml Outdated
@rbanka1 rbanka1 changed the title semgrep add Semgrep SAST and secrets scan workflow Oct 19, 2026
Comment thread .github/workflows/semgrep.yml Outdated
@@ -0,0 +1,5 @@
# Copyright (c) 2026 Intel Corporation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

-f VAL, -c VAL, --config=VAL (absent SEMGREP_RULES env)
           YAML configuration file, directory of YAML files ending in
           .yml|.yaml, URL of a configuration file, or Semgrep registry entry
           name.

ref. https://docs.semgrep.dev/cli-reference

can you please move it into .github dir?

@rbanka1
rbanka1 force-pushed the scan branch 2 times, most recently from 3f9760a to 00f3e40 Compare October 21, 2026 10:55
Add a Semgrep CI workflow that runs code (SAST) and secrets scanning on pull requests, workflow_dispatch, and push to the main branch. The job runs on the semgrep/semgrep container, checks out the repository.

Signed-off-by: Renata Banka <renata.banka@intel.com>
@lukaszstolarczuk
lukaszstolarczuk merged commit 6645a07 into main Oct 21, 2026
9 checks passed
@lukaszstolarczuk
lukaszstolarczuk deleted the scan branch October 21, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants