You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[JAX] Update simple accuracy tests to support optional XLA optimizations - #2618
With xla_cpu_experimental_onednn_custom_call=true, layer's output may differ due to different computation path after JIT optimization, which results in failing test. This PR adds alternative way of computing expected values in the test so it matches the ones that we have with xla_cpu_experimental_onednn_custom_call
Additionally XLA with xla_allow_excess_precision=true (Default) increases computation accuracy by dropping unnecessary casts from higher to lower precision floats. This PR adjusts tests also for that
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Compiler-dependent numerical assumptions need validation against JIT outputs with oneDNN enabled and excess precision both enabled and disabled.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Add accuracy coverage for oneDNN and excess-precision branches
test/jax/jax_test_utility.py:150
The existing accuracy test compares this helper with JIT output, but it does not vary XLA_FLAGS, and .azure-pipelines/scripts/ut/run_3x_jax.sh:33 runs it only once with inherited flags. This leaves the new oneDNN and excess-precision branches without explicit regression coverage. Add separate accuracy-test processes for the default route and for oneDNN enabled with xla_allow_excess_precision=true and false. Set the flags before JAX initializes so each expected-output path is checked against the corresponding compiled model.
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
wpietka
changed the title
[JAX] Update simple accuracy tests to support custom OneDNN kernel output calculations
[JAX] Update simple accuracy tests to support optional XLA optimizations
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
bug_fix
Description
With xla_cpu_experimental_onednn_custom_call=true, layer's output may differ due to different computation path after JIT optimization, which results in failing test. This PR adds alternative way of computing expected values in the test so it matches the ones that we have with xla_cpu_experimental_onednn_custom_call
Additionally XLA with xla_allow_excess_precision=true (Default) increases computation accuracy by dropping unnecessary casts from higher to lower precision floats. This PR adjusts tests also for that