Repository navigation
Enhance QDQ patching for marlin_gemm and moe_wna16_marlin_gemm with i… - #2615
Merged
Merged
Conversation
…mproved parameter handling and custom op support Signed-off-by: Xin He <xin3.he@intel.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Signature compatibility and exactly-once QDQ through custom-op interception remain unvalidated by regression tests.
2 open findings
What changed in this PR
Updates the vLLM QDQ plugin to accommodate vLLM 0.31 Marlin signatures and dense custom-op execution.
Changes:
- Replaces fixed wrappers with signature-aware argument handling and legacy fallbacks.
- Adds dense custom-op interception, selecting one patch layer to avoid duplicate QDQ.
| File | Description |
|---|---|
benchmark/vllm-qdq-plugin/src/vllm_qdq_plugin/patch.py |
Adds adaptive wrappers and dense custom-op patch selection. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
yiliu30
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mproved parameter handling and custom op support
Type of Change
feature/bug fix/documentation/validation/others
Description
For vllm==0.31.0, _patch_moe_marlin_gemm.._patched() missing 3 required positional arguments: 'num_tokens_past_padded', 'topk_weights', 'is_k_full'。
VLLM_QDQ 插件里 patch 的函数签名和当前 vLLM 的 moe_marlin_gemm 对不上，需要在 vllm-qdq-plugin 里把签名改成和当前 vLLM 一致。
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed