[SYCL] Fix kernel range check for interop kernels - #23099
Open
uditagarwal97 wants to merge 4 commits into
Open
Conversation
isInteropOrSourceBased() is also true for kernel_compiler images built from SYCL source. Those do have a device image carrying the idQueriesRange property and do truncate id queries to int by default, so skipping the check for them turns a clear exception into silently wrong ids. hasSYCLMetadata() excludes exactly the interop and non-SYCL-source kernels, which have no property to read.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression test lacks a required USM capability gate and dispatches billions of work-items synchronously.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates kernel range validation so metadata-free interop and non-SYCL kernels use size_t semantics.
Changes:
- Distinguishes kernels with SYCL metadata during range validation.
- Adds an OpenCL interop regression test for ranges above
INT_MAX.
File summaries
| File | Description |
|---|---|
sycl/source/detail/scheduler/commands.cpp |
Handles metadata-free kernels as supporting size_t ranges. |
sycl/test-e2e/Regression/interop_kernel_large_range.cpp |
Tests a large-range OpenCL interop launch. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interop kernels and kernels built from a non-SYCL source language (OpenCL C, SPIR-V) carry no SYCL metadata, so there is no id queries range property to read; their id queries are size_t by definition.