[SYCL][E2E] Fix LIT feature name - #23088
Conversation
| @@ -1,4 +1,4 @@ | |||
| // REQUIRES: gpu, level-zero | |||
There was a problem hiding this comment.
I suggest removing -/_ from the lit feature name to avoid similar bugs in the future. It won't prevent other typos, but this specific one is just ridiculous.
There was a problem hiding this comment.
We have a lot of LIT features with - or _ in their name, renaming all of them would be a big change. How about we instead make LIT throw an error if it encounters an unknown LIT feature?
IIRC we already maintain a list of approved LIT features to decide if it's build-time or runtime feature.
There was a problem hiding this comment.
We have a lot of LIT features with
-or_in their name, renaming all of them would be a big change. How about we instead make LIT throw an error if it encounters an unknown LIT feature? IIRC we already maintain a list of approved LIT features to decide if it's build-time or runtime feature.
That's a good idea, I believe we have more typos. I tried to implement it previously, but it got bogged down in discussion.
There was a problem hiding this comment.
@KornevNikita I like the solution you proposed in #16019 - it's easy to maintain, extend, and require minimal changes. Let me try it out
|
@intel/unified-runtime-reviewers-level-zero ping |
This test always gets skipped due to incorrect LIT feature name.