[SYCL] Add sycl_khr_properties container and classification traits - #23075
[SYCL] Add sycl_khr_properties container and classification traits#23075koparasy wants to merge 1 commit into
Conversation
|
@koparasy the khr extension you are referring to is in draft state. Do you expect it to be reviewed and merged in advance? @dm-vodopyanov, @gmlueck I am not aware about process for this case, could you please clarify? |
@KseniyaTikhomirova the KHR is expected to be updated and be undrafted (soonish). I don't know the process, but the code is guarded with the |
KseniyaTikhomirova
left a comment
KseniyaTikhomirova
left a comment
There was a problem hiding this comment.
I have found that we have a process for this https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/KHRExtensions.md
To me it looks like draft/unmerged PRs against main are not intended to be merged in advance. Although I don't work with extensions so may be wrong here. @dm-vodopyanov kindly ping for your opinion.
changes itself LGTM, just a few comments
| is_property_v<alignment_key::__detail_property_t<alignment_key, int, 4>>); | ||
| static_assert(!is_property_v<int> && !is_property_v<enable_profiling_key>); | ||
| static_assert(is_property_key_v<enable_profiling_key> && | ||
| is_property_key_v<alignment_key> && |
There was a problem hiding this comment.
&& for alignment_type_key?
|
|
||
| // is_property_key_for / is_property_for / is_property_list_for. | ||
| static_assert(is_property_key_for_v<enable_profiling_key, MyClass>); | ||
| static_assert(!is_property_key_for_v<enable_profiling_key, OtherClass>); |
There was a problem hiding this comment.
would be nice to have this check for all types of properties
| static_assert(!empty_properties_t::has_property<enable_profiling_key>()); | ||
|
|
||
| // is_property_list_for over a populated and the empty list. | ||
| static_assert(is_property_list_for_v<decltype(p), MyClass>); |
There was a problem hiding this comment.
can we have a diagnostic test for the case when property list contains properties applicable to different classes to check that these traits handle it correctly?
2 participants
This is partial implementation of KhronosGroup/SYCL-Docs#980