Skip to content

[SYCL] Do not release threadpool resources on Windows during shutdown #23067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uditagarwal97 merged 2 commits into from
Sep 4, 2026
+16 −2
Merged

[SYCL] Do not release threadpool resources on Windows during shutdown #23067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1821a8
[SYCL] Do not release threadpool resources on Windows during shutdown
uditagarwal97 Sep 1, 2026
bbd95c4
Update global_handler.cpp
uditagarwal97 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions sycl/source/detail/global_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,16 @@ void shutdown_early(bool CanJoinThreads = true) {
// upon its release
GlobalHandler::RTGlobalObjHandler->prepareSchedulerToRelease(true);

if (GlobalHandler::RTGlobalObjHandler->MHostTaskThreadPool.Inst) {
// Do not cleanup thread pool on windows during application shutdown.
// Let OS do the cleanup.
bool doThreadPoolCleanup =
GlobalHandler::RTGlobalObjHandler->MHostTaskThreadPool.Inst.get() !=
nullptr;
#ifdef _WIN32
doThreadPoolCleanup &= !CanJoinThreads;
#endif

if (doThreadPoolCleanup) {
Comment thread
uditagarwal97 marked this conversation as resolved.
GlobalHandler::RTGlobalObjHandler->MHostTaskThreadPool.Inst->finishAndWait(
CanJoinThreads);
GlobalHandler::RTGlobalObjHandler->MHostTaskThreadPool.Inst.reset(nullptr);
Expand Down Expand Up @@ -373,8 +382,13 @@ void shutdown_late() {

GlobalHandler::RTGlobalObjHandler->MXPTIRegistry.Inst.reset(nullptr);

// Release the rest of global resources.
#ifndef _WIN32
// Release the rest of global resources. Do not release GlobalHandler
// on Windows and let OS reclaim leaked memory. Releasing GlobalHandler
// on Windows can seg fault if application uses host tasks, as there
// can be a race between host tasks and shutdown.
delete GlobalHandler::RTGlobalObjHandler;
Comment thread
uditagarwal97 marked this conversation as resolved.
#endif
GlobalHandler::RTGlobalObjHandler = nullptr;
}

Expand Down
Loading