Skip to content

Move leftover copies in SYCL profiling tools #23054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hashim1999164 wants to merge 1 commit into
base: sycl
Choose a base branch
from
+6 −4
Open

Move leftover copies in SYCL profiling tools #23054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sycl/tools/sycl-prof/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include <iostream>
#include <string>
#include <utility>

using namespace llvm;

Expand Down Expand Up @@ -41,7 +42,7 @@ int main(int argc, char **argv, char *env[]) {
}

std::string ProfOutFile = "SYCL_PROF_OUT_FILE=" + OutputFilename;
NewEnv.push_back(ProfOutFile);
NewEnv.push_back(std::move(ProfOutFile));
NewEnv.push_back("XPTI_FRAMEWORK_DISPATCHER=libxptifw.so");
NewEnv.push_back("XPTI_SUBSCRIBERS=libsycl_profiler_collector.so");
NewEnv.push_back("XPTI_TRACE_ENABLE=1");
Expand Down
7 changes: 4 additions & 3 deletions sycl/tools/xpti_helpers/usm_analyzer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <string>
#include <string_view>
#include <thread>
#include <utility>

struct TracepointInfo {
std::string Source;
Expand Down Expand Up @@ -286,7 +287,7 @@ class USMAnalyzer {
Info.Location = GS.LastTracepoint;
Info.Length = *Params->psize;
Info.Kind = AllocKind::host;
GS.ActivePointers[**Params->pppMem] = Info;
GS.ActivePointers[**Params->pppMem] = std::move(Info);
}

static void handleUSMDeviceAlloc(const ur_usm_device_alloc_params_t *Params) {
Expand All @@ -296,7 +297,7 @@ class USMAnalyzer {
Info.Location = GS.LastTracepoint;
Info.Length = *Params->psize;
Info.Kind = AllocKind::device;
GS.ActivePointers[**Params->pppMem] = Info;
GS.ActivePointers[**Params->pppMem] = std::move(Info);
}

static void handleUSMSharedAlloc(const ur_usm_shared_alloc_params_t *Params) {
Expand All @@ -305,7 +306,7 @@ class USMAnalyzer {
Info.Location = GS.LastTracepoint;
Info.Length = *Params->psize;
Info.Kind = AllocKind::shared;
GS.ActivePointers[**Params->pppMem] = Info;
GS.ActivePointers[**Params->pppMem] = std::move(Info);
}

static void handleUSMFree(const ur_usm_free_params_t *Params) {
Expand Down
Loading