Update async-profiler to v3.0g2#1044
Open
mlim19 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the pinned async-profiler build version used by gprofiler’s shared-library build script to pick up async-profiler v3.0g2, enabling improved thread-name attribution when Java threads are renamed during profiling.
Changes:
- Bump async-profiler version from
v3.0g1tov3.0g2. - Update the pinned async-profiler git revision to the corresponding commit SHA.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkorlovs
force-pushed
the
async-profiler-v3.0g2
branch
from
af581ec to
1d57fc5
Compare
This version adds support for tracking Java thread renames in samples, allowing accurate thread name attribution when threads are renamed during profiling (e.g., in thread pools). Changes in async-profiler v3.0g2: - Enable capturing thread names for every sample - Use atomic builtins for thread-safe name index access - Add compile-time checks for encoding constraints - Log warning when thread name table capacity is reached Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
/rerun |
dkorlovs
previously approved these changes
Jun 16, 2026
Comment on lines
+1068
to
+1072
| ProfilerArgument( | ||
| "--java-collect-thread-names", | ||
| dest="java_collect_thread_names", | ||
| action="store_true", | ||
| default=False, |
dkorlovs
force-pushed
the
async-profiler-v3.0g2
branch
from
71a11a2 to
c95c29f
Compare
dkorlovs
force-pushed
the
async-profiler-v3.0g2
branch
from
c95c29f to
c491f8b
Compare
Signed-off-by: Min Yeol Lim <min.yeol.lim@intel.com>
Comment on lines
39
to
45
| lower_profiler_name = profiler_name.lower() | ||
| profiler_mode = user_args.get(f"{lower_profiler_name}_mode") | ||
| if is_profiler_disabled(cast(str, profiler_mode)): | ||
| # Warn if Java-specific options are set but Java profiling is disabled | ||
| if profiler_name == "Java" and user_args.get("java_collect_thread_names"): | ||
| logger.warning("--java-collect-thread-names is ignored because Java profiling is disabled") | ||
| continue |
| self._collect_meminfo = collect_meminfo | ||
| self._include_method_modifiers = ",includemm" if include_method_modifiers else "" | ||
| self._include_line_numbers = ",includeln" if java_line_numbers == "line-of-function" else "" | ||
| self._threads_enabled = ",threads" if collect_thread_names else "" |
Comment on lines
+1001
to
+1009
| ProfilerArgument( | ||
| "--java-collect-thread-names", | ||
| dest="java_collect_thread_names", | ||
| action="store_true", | ||
| default=False, | ||
| help="Enable per-sample thread name tracking. When enabled, each stack trace sample records " | ||
| "the thread name at sample time, allowing accurate attribution when threads are renamed " | ||
| "(e.g., in thread pools). Adds ~256KB memory and periodic thread name polling overhead.", | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows accurate thread name attribution when threads are renamed during profiling (e.g., in thread pools, reactive frameworks like Netty/Project Reactor).
Changes in async-profiler v3.0g2:
Test plan
🤖 Generated with Claude Code