Repository navigation
Conversation
Two docker-* cells of the same task in one suite process got the same dokimi-run-<task>-<pid> name; the second cell's rm -f removed the first's container. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 92.01% 92.02%
=======================================
Files 223 223
Lines 27768 27768
Branches 4563 4563
=======================================
+ Hits 25552 25554 +2
+ Misses 1570 1569 -1
+ Partials 646 645 -1
🚀 New features to boost your workflow:
|
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
napetrov
marked this pull request as ready for review
October 25, 2026 00:37
napetrov
requested review from
antonwolfy,
jharlow-intel,
vchamarthi and
xaleryb
as code owners
October 25, 2026 00:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A suite runs every harness cell in one process, so
dokimi-run-<task>-<pid>repeated whenever two cells ran the same task. Now the name ends in 3 random bytes (os.urandom(3).hex()). Thedokimi-run-prefix stays, so cleanup globs still match.Evidence
test_two_runs_of_one_task_in_one_process_get_their_own_container: fails on main, passes here.tests/test_container_agent.py tests/test_task_formats.py: 234 passed, 1 skipped. ruff clean.docker_solver.pystays at its 927-line growth limit.Merge Danger
Low. Anything that guessed the container name from the pid alone would no longer find it; nothing in the repo does.
🤖 Generated with Claude Code