Repository navigation
Conversation
A probe registry (dokimi.task_formats) names the format of a file, a task directory or a tree, and reports kind, item count, present/missing parts, lint problems and which dokimi backends consume it today. Probes: harbor and task-md (wrapping harnesses.tasks), terminal-bench v1, SWE-bench, Inspect AI samples and @task files (text scan, never imported), OpenAI evals, skill-creator evals.json and trigger sets, skill-reach QuerySet, promptfoo and dokimi questions. Unknown paths get a best-effort structure report; malformed files are lint problems. Detection only: nothing new runs. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
CLI interface change detectedThis PR changes dokimi's user-facing CLI surface (commands and/or options): + added command `dokimi catalog formats`
+ option `--help/-h`
+ option `--json`
+ option `--root`
+ added command `dokimi tasks inspect`
+ argument `path`
+ option `--help/-h`
+ option `--json`
~ `dokimi catalog trigger-set` parameters changed:
+ added option `--trigger-set`
~ changed option `--questions`: required: True -> FalseUpdated on every push; the |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 92.01% 91.97% -0.05%
==========================================
Files 223 231 +8
Lines 27768 28701 +933
Branches 4563 4716 +153
==========================================
+ Hits 25552 26398 +846
- Misses 1570 1615 +45
- Partials 646 688 +42
🚀 New features to boost your workflow:
|
napetrov
force-pushed
the
feat/run-trigger-formats
branch
from
October 24, 2026 17:13
29df5da to
f7abf7c
Compare
Readers for the three trigger-set formats dokimi already writes (skill-reach QuerySet, skill-creator / agentskills.io eval queries, questions with expected_skill) into TriggerQuery, held to the writers by round-trip tests. catalog trigger-set --trigger-set relints an imported set against the catalog and hands it to the skill-catalog: arm; arms run points external sets at it. catalog formats names the skill/rule packages of other ecosystems (Cursor rules, Copilot instructions, Gemini extensions, Claude plugins) next to agentskills.io SKILL.md, with spec lint and the selecting mechanism. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Hits over the questions where the arm loaded any skill, strict on multi-load like recall; rendered in the arms report's Skill selection table. Replaces the ad-hoc calculation used for the intel#211 evidence table. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
This was referenced Oct 24, 2026
napetrov
marked this pull request as ready for review
October 25, 2026 00:36
napetrov
requested review from
antonwolfy,
jharlow-intel,
vchamarthi and
xaleryb
as code owners
October 25, 2026 00:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #210 (feat/task-format-detect). Review the commits after #210: f7abf7c, 19822ba (
precisioninskill_selection_summary). The fix for vendored-skill discovery is a separate PR, #215.Summary
dokimi could already write three trigger-set formats. With this PR it can read them too and run them through the existing
skill-catalog:arm. It adds no new runner.Evidence
arms run --questions reach.jsonfailed in the questions loader, andtasks inspectgave no consumer for skill-reach or skill-creator sets.After:
catalog trigger-set --trigger-set reach30.json --format questionsreads the file and re-lints it (30 queries: 19 exam-framed, 17 echo). Arms then score it. The round-trip tests (writer, then reader, gives the same labels) are intests/test_trigger_set_readers.py, and the package scan tests are intests/test_skill_formats.py. The full suite passes locally (7834), along with ruff and mypy.skill_selection_summarynow reportsprecision, which is hits over the questions where any skill loaded. The arms report shows it as a column. The precision figures below came from an ad-hoc script that used the same definition.skill-catalog:with reach30, 33 skillsskill-catalog:with onetbb skill-creator set, 33 skillsskill-catalog:with onetbb skill-creator set, target alonerun_eval.pynative (anthropics/skills@dbd4588), haikuThe tool-calling proxy triggers too often compared with the real harnesses. The import path is unaffected by this; it is the same finding as before.
Merge Danger
Door: two-way
Additive only: two new CLI options or subcommands and a new module.
--questionsoncatalog trigger-setis no longerrequired(at least one source is still enforced).Blast Radius: small
A skill-creator negative is read as "no skill should load". In a catalog of more than one skill, loading a rival skill therefore counts as a false trigger. The CLI warns about this.
🤖 Generated with Claude Code